Closed ethanjli closed 3 years ago
@Sudhir-dev Can you review the changes I made on the frontend to see if anything looks wrong, as well as try to test out the new alarms-related functionality by running the frontend and the backend simulator (which is now ventserver.simulator
instead of ventserver.simulation
) together, to identify any behavior which looks questionable?
@renjipanicker Just a heads-up, in this PR I've fixed the decomposition of functionalities between firmware/ventilator-controller-stm32/Core/Inc/Pufferfish/Protocols/States.tpp
and firmware/ventilator-controller-stm32/Core/Inc/Pufferfish/Application/States.tpp
. Previously, the Protocols/States.tpp
file contained some application-specific logic in the StateSynchronizer::input
method for checking which message types to allow; that was something I had forgotten to update previously, so here I have moved that into a new States::should_input
static method in Applications/States.tpp
.
@Sudhir-dev Can you review the changes I made on the frontend to see if anything looks wrong, as well as try to test out the new alarms-related functionality by running the frontend and the backend simulator (which is now
ventserver.simulator
instead ofventserver.simulation
) together, to identify any behavior which looks questionable?
I have verified. Alarm is triggered based on alarm limit configured
This PR:
Range
message type.ventserver.simulation
toventserver.simulator
, assimulation
is now a subpackageFor records-keeping: