firmware: remove handling of data inputs from StateSynchronizer - Githubissues

pez-globo / pufferfish-software

All software for the Pufferfish ventilator.

Apache License 2.0

0 stars 1 forks source link

firmware: remove handling of data inputs from StateSynchronizer #289

Closed rohanpurohit closed 3 years ago

rohanpurohit commented 3 years ago

This PR resolves #279 Changes:

Application/State input & output methods return error codes
states is responsible for handling inupt in backend.tpp
remove status code for StateSynchronizer::input
Add an invalid_type error code for StateSynchronizer::output
Use Util::within_timeout in StateSynchronizer::should_output
Update states::input method
Move Application/States should_input method to backend.tpp

For records-keeping:

This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
Were any of these contributions also part of work you did for an employer or a client? No
Does this work include, or is it based on, any third-party work which you did not create? No

ethanjli commented 3 years ago

Works fine on the microcontroller, let's merge this!