Closed ethanjli closed 3 years ago
@Sudhir-dev Can you try running the frontend with the backend simulator to see if you can catch any issues or suspicious behaviors which might've slipped past me? And can you also review the changes to the protobuf definitions and the events log-related frontend files, and share any observations or questions you might have?
For records-keeping:
This PR:
Updates protocol buffer message definitions:
old_value
andnew_value
, and reorders fieldsUpdates the frontend:
Updates the backend:
backend/tests/unit/protocols/test_file.py
because I didn't write those tests and I don't have instructions for how to update the test examples for the new protobuf field orderings. This will need to be fixed in a future PR, and it should be fixed before any changes are made to the filesystem-related protocols. (@Tanmay06 do you have any personal notes about how you generated these examples and/or how I should go about updating them? If not, @rohanpurohit this might be a new task for you, though lower priority than firmware-related tests)