Improve COBS & add unit test cases for Backend/Frames

pez-globo / pufferfish-software

All software for the Pufferfish ventilator.

Apache License 2.0

0 stars 1 forks source link

Improve COBS & add unit test cases for Backend/Frames #303

Closed rohanpurohit closed 3 years ago

rohanpurohit commented 3 years ago

This PR includes:

Update COBS interface to fix resizing and change encode_cobs algorithm to account for edge cases for eg: a 254-byte buffer and buffers of size greater than 255.
rename the read_ntoh function to read_bigend for better understanding.
add Unit test cases for backend/Frames.h

rohanpurohit commented 3 years ago

@ethanjli PR is ready for review. thanks

rohanpurohit commented 3 years ago

This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes.
Were any of these contributions also part of work you did for an employer or a client? No.
Does this work include, or is it based on, any third-party work which you did not create? No.

ethanjli commented 3 years ago

Let's merge the latest version of develop back into this branch, and then try running the firmware with these changes to ensure that there are no regressions or subtle merge conflicts. Afterwards, I'll mark the formal approval on Github.