pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

Frontend UI bugs #304

Closed Sudhir-dev closed 3 years ago

Sudhir-dev commented 3 years ago

Addressing following Bug fixes mentioned in PR #296

  • The upper-right close button of the Events Log modal is not aligned with the upper-right close button of the breadcrumbs modal; and the titles of the two modals aren't consistent in position or text styling (bold vs. non-bold)
  • The dotted line border around the table for the Events Log modal is awkward - the left and right edges are right next to the modal. Maybe it'd be better to completely remove the dotted edge border for the Events Log modal?
  • When I switch between the Events Log modal and the Active Alarms modal, the sizes of the content container seem to be different, so the elements which are the same in both modals move. Also, the alarm mute button moves when I switch between the two.
  • When I have 4 events in the Events Log modal, a vertical scrollbar appears; there should never be any scrollbar in the modals.
  • The names of the second-layer breadcrumbs don't match the names specified in the Adobe XD design. For example, what the Adobe XD design specifies as "Flow Rate Settings" for the breadcrumb title is currently listed as "Set New"; and what the Adobe XD design specifies as "SpO2 Alarms" is currently listed as "Alarms". I would suggest following the Adobe XD design's breadcrumb naming so that different screens on the modal will have different breadcrumb path names
Sudhir-dev commented 3 years ago
  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
  2. Were any of these contributions also part of work you did for an employer or a client? No
  3. Does this work include, or is it based on, any third-party work which you did not create? No
ethanjli commented 3 years ago

As discussed in the meeting for this PR:

For one or two separate PRs:

Sudhir-dev commented 3 years ago

@ethanjli Updated PR with fixes for following points

  • We will globally replace the "x" icon of the close button with the "back" button used elsewhere in the frontend
  • The "Events Log" button from the topbar should always open the "Events Log" view, rather than the last view selected