search

pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

Frontend UI fixes #305

Closed Sudhir-dev closed 3 years ago

Sudhir-dev commented 3 years ago

This PR addresses following comments mentioned in PR #304

For one or two separate PRs:

  • It'd be great to have absolute positioning of the pagination controls in the Events Log modal. It's fine if they're absolutely positioned to the lower left or the lower right, if one is simpler
  • The Events Log should pull alarm limits from the log event objects, rather than from the store

Looks great! I just realized that I had forgotten to write down another issue to fix: making the height of the table rows in the Event Log constant, so that it's the same whether or not the "Settings" button is shown in a row. We could fix this in this PR, or in the next one; I'll approve this PR for merging in case you want to fix it in the next PR.

ethanjli commented 3 years ago

Looks great! For records-keeping:

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too?
  2. Were any of these contributions also part of work you did for an employer or a client?
  3. Does this work include, or is it based on, any third-party work which you did not create?
Sudhir-dev commented 3 years ago
  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
  2. Were any of these contributions also part of work you did for an employer or a client? No
  3. Does this work include, or is it based on, any third-party work which you did not create? No