pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

Landing Screen should only allow going to Quick Start once backend is available #325

Closed ethanjli closed 3 years ago

ethanjli commented 3 years ago

Right now the landing screen allows the user to bypass the "start" button by clicking on the sidebar; we should remove the sidebar. Additionally, the "start" button always works, even if the backend is not available - in which case pressing the "start" button takes the user to the Quick Start screen and immediately triggers the "backend connection lost!" alarm. We should prevent the "start" button from allowing this. The simple approach we discussed was to disable the "start" button and make it say something like "Loading..." or "Connecting..." instead of "Start" while the backend is unavailable.

(this issue was created from https://github.com/pez-globo/pufferfish-software/pull/313#issuecomment-818406959 )

ethanjli commented 3 years ago

See https://github.com/pez-globo/pufferfish-software/blob/7a046d81b0b995a59f5a33e060fccddf60670a85/frontend/src/modules/app/OverlayScreen.tsx#L45 for inspiration and/or reuse

rohanpurohit commented 3 years ago

@ethanjli can you confirm if 8128529902bbf1cad89d2737e5edbbb3dbfa0db9 is the behaviour we would need and are there any regressions from it? changes: