search

pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

frontend: fix apply changes button behaviour #332

Closed rohanpurohit closed 3 years ago

rohanpurohit commented 3 years ago

This PR fixes part of #324 comment, by disabling the apply changes button in standby mode (I'm not sure if it's the most elegant solution)

and fix the surface-level issue in #331

ethanjli commented 3 years ago

I've lightly tested it and it works - thanks for discovering and fixing this! Let's merge this in. For records-keeping:

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too?
  2. Were any of these contributions also part of work you did for an employer or a client?
  3. Does this work include, or is it based on, any third-party work which you did not create?
rohanpurohit commented 3 years ago
  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes.
  2. Were any of these contributions also part of work you did for an employer or a client? No.
  3. Does this work include, or is it based on, any third-party work which you did not create? No.