Closed rohanpurohit closed 3 years ago
Few observations that still exist and are mostly related to how the alarmMuteStatus store and then the local state is behaving:
other than that, muting the alarm seems to be fine when we don't navigate from the dashboard. probably is a very small fix to solve the above-mentioned issues but needs debugging.
I'm unable to reproduce item 1 when I test with the simulator. Patient alarms should indeed be cancelled in quickstart (this is taken care of by AlarmsService, and new alarms get triggered when ventilation starts again if the condition is still there to trigger the alarm), though we'll want to have the low battery alarm still active in quickstart. I'm also unable to reproduce item 2. Can you file a new issue for each of these things, and we can follow up on them separately from this PR? I suspect they are independent problems from the audio playing: it sounds like item 2 related to the implementation of the alarm muting (which will definitely be changed), while item 1 is something else.
I'm unable to reproduce item 1 when I test with the simulator. Patient alarms should indeed be cancelled in quickstart (this is taken care of by AlarmsService, and new alarms get triggered when ventilation starts again if the condition is still there to trigger the alarm), though we'll want to have the low battery alarm still active in quickstart. I'm also unable to reproduce item 2. Can you file a new issue for each of these things, and we can follow up on them separately from this PR? I suspect they are independent problems from the audio playing: it sounds like item 2 related to the implementation of the alarm muting (which will definitely be changed), while item 1 is something else.
maybe I dint describe the first item properly
will create issues and we can take it from there.
Currently:
Bugs:
mute icon
twice to get it working.Can be reproduced on develop as well. seems to be a state issue or useEffect