search

pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

Buggy mute alarm button behaviour #346

Closed rohanpurohit closed 3 years ago

rohanpurohit commented 3 years ago

Currently, there is inconsistent behavior of muting the alarm when ventilation is restarted or when we navigate to a different page from the dashboard, the behavior is consistent on the dashboard.

steps to reproduce:

  1. start ventilation
  2. wait for an alarm to be triggered
  3. pause ventilation and start ventilation again
  4. wait for alarm if not active
  5. press the mute button, the mute button needs to be toggled twice to stop the alarm sound.

This behavior can also be noticed on the landing screen when the backend is lost. again it's inconsistent.

Additional context:

rohanpurohit commented 3 years ago

another example of this behaviour is when ventilation is running, an alarm is triggered for example: HR too low, the alarm is muted, therefore alarmMute.active = true, the mentioned alarm is then deactivated and a new alarm HR too high is triggered, since the previous state was true, we would need to toggle twice for the sound to stop.