search

pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

Initialize frontend rotary encoder state from the backend #351

Closed ethanjli closed 3 years ago

ethanjli commented 3 years ago

This PR fixes #349 by making the frontend's rotary encoder reducer handle the case where its state is null (which is always how the frontend starts) and it receives a RotaryEncoder message from the backend. This is a very tiny hotfix and I've tested it on my Raspberry Pi setup; @raavilagoo once you test it and confirm that the frontend responds when you turn the rotary dial, I'll merge in this PR. For records-keeping:

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
  2. Were any of these contributions also part of work you did for an employer or a client? No
  3. Does this work include, or is it based on, any third-party work which you did not create? No
raavilagoo commented 3 years ago

Rotary encoder test passed on this commit. Frontend responds to Rotary dial.