Closed ethanjli closed 3 years ago
Everything looks good. tried to generate erroneous/extra log events multiple times on disconnecting/reconnecting MCU and it works as expected.
Great! Then I'll merge in this PR as prototype-grade code. For records-keeping:
For future PRs, let's start having you use Github's Code Review approvals feature, where if it looks good to you according to the review criteria (which could just be testing the functionality, or could also include code review if you want), then you'll do the formal Github approval. Thanks!
This PR fixes #341 by:
Parameters
andAlarmLimits
request/response services only generate log events for parameters and alarm limits changes (besides ventilation start/stop) after the firstParametersRequest
andAlarmLimitsRequest
messages have been received from the backend, respectively. This means that unplugging the MCU and plugging it back in while the firmware is running will generate log events on loss and reestablishment of the MCU-backend connection (provided by #344) and on stoppage and starting of ventilation, but it won't clutter the event log with redundant parameter & alarm limits change events.ParametersRequest
and an initialAlarmLimitsRequest
.Pufferfish::Application::States
class to thePufferfish::Application::Store
class, to be consistent with naming in the backend and frontend.Note: this PR does not provide the same behavior in the backend simulator. This should happen in a future PR, after/when functionality is added to save/load the event log from the filesystem. Only after that's done would we be able to test it.
This PR should be merged after #344 is merged into develop.