pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

Don't log ParametersRequest & AlarmLimitsRequest initialization in firmware #352

Closed ethanjli closed 3 years ago

ethanjli commented 3 years ago

This PR fixes #341 by:

Note: this PR does not provide the same behavior in the backend simulator. This should happen in a future PR, after/when functionality is added to save/load the event log from the filesystem. Only after that's done would we be able to test it.

This PR should be merged after #344 is merged into develop.

rohanpurohit commented 3 years ago

Everything looks good. tried to generate erroneous/extra log events multiple times on disconnecting/reconnecting MCU and it works as expected.

ethanjli commented 3 years ago

Great! Then I'll merge in this PR as prototype-grade code. For records-keeping:

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
  2. Were any of these contributions also part of work you did for an employer or a client? No
  3. Does this work include, or is it based on, any third-party work which you did not create? No

For future PRs, let's start having you use Github's Code Review approvals feature, where if it looks good to you according to the review criteria (which could just be testing the functionality, or could also include code review if you want), then you'll do the formal Github approval. Thanks!