frontend: show unsaved changes to alarm limits in HFNC control - Githubissues

pez-globo / pufferfish-software

All software for the Pufferfish ventilator.

Apache License 2.0

0 stars 1 forks source link

frontend: show unsaved changes to alarm limits in HFNC control #362

Closed rohanpurohit closed 3 years ago

rohanpurohit commented 3 years ago

This PR fixes:

HFNC control not showing unsaved alarm limit changes (removes previous change merged in develop)
parameter settings instead of measurements as the large values for fio2 and flow
Toolbar: remove copy-pasted code from AlarmsPage

few points about the changes I have made:

while attempting to make the changes, I realized interface Props:alarmValues which are the local unsaved alarm limit changes in multistepwizard or multipopup, are not initialized until we actually click on one of the LargeValueInfo components.
To fix the above issue I made the change in ValueInfo: which will just show AlarmLimitsRequest until the state passed from multistepwizard is not undefined or of length 0.

rohanpurohit commented 3 years ago

@ethanjli This PR is ready for testing/code review. thanks.

rohanpurohit commented 3 years ago

This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes.
Were any of these contributions also part of work you did for an employer or a client? No.
Does this work include, or is it based on, any third-party work which you did not create? No.