search

pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

Unit Tests for Util #366

Closed raavilagoo closed 3 years ago

raavilagoo commented 3 years ago

Unit Test for following files 1.Array 2.Bytes 3.Endian 4.Ranges

  1. Vector
raavilagoo commented 3 years ago

Hi @ethanjli , I have updated this branch with expected changes.

rohanpurohit commented 3 years ago

It looks like we'll be moving this to v0.13 and finish it as early as possible @ethanjli

raavilagoo commented 3 years ago

@ethanjli ,This pull request is ready for review.

raavilagoo commented 3 years ago

@ethanjli ,This pull request is ready for review.

raavilagoo commented 3 years ago

@ethanjli , Pull request is ready to review. I will make the expected changes in vector test cases in next pull request.

ethanjli commented 3 years ago

Sounds good - there are other clarity issues which need to be improved in vector.txt: basically the same kinds of issues we discussed last meeting, except they're in the new changes you had added to vector.txt after that meeting. Since you plan to save the other changes for vector.txt for the next PR, let's merge this PR in for v0.13, and save those fixes for your next PR. For the next PR, let's try:

  1. Making new commits for each round of changes you make, instead of force-pushing. I suspect this might be related to some of the weird behavior Github is doing with comment replies, and also force-pushing prevents me from seeing which changes you made between commits.
  2. Before editing or creating any cpp files for test implementation, first we'll get the txt files for behavior specification through a few rounds of review so that they're mature.

For records-keeping:

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too?
  2. Were any of these contributions also part of work you did for an employer or a client?
  3. Does this work include, or is it based on, any third-party work which you did not create?
raavilagoo commented 3 years ago

1.This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? - Yes 2.Were any of these contributions also part of work you did for an employer or a client? -No 3.Does this work include, or is it based on, any third-party work which you did not create? No

raavilagoo commented 3 years ago

@ethanjli , I have gone through your suggestions,

  1. I will avoid force pushing for future PRs.
  2. I agree, It would be helpful if we can decide the scope of Unit tests, I can get started with txt files first. Then we can have discussion on same.