pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

Move signal smoothing into the firmware #368

Closed ethanjli closed 3 years ago

ethanjli commented 3 years ago

This PR:

This PR does not:

@rohanpurohit If you can't test the firmware with a Nonin OEM III sensor connected to measure your SpO2 and HR (the Nonin sensor gives noisy values which fluctuate a lot), I would suggest playing around with the parameters in BreathingCircuit/SignalSmoothing.h for the ConvergenceSmoother to understand how they affect the smoothing behavior, as a way of testing my code using the firmware's noisy simulated values. For now, it should be fine to ignore the ewma_responsiveness parameter because I've currently set that parameter to 1 to disable exponential-weighted moving average, as we'll need to tune that parameter for FiO2 and Flow in an actual ventilator.

rohanpurohit commented 3 years ago

@ethanjli I have fixed the test cases in this branch hotfix/firmware-test-messages, I will test and review soon.

ethanjli commented 3 years ago

For records-keeping:

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
  2. Were any of these contributions also part of work you did for an employer or a client? No
  3. Does this work include, or is it based on, any third-party work which you did not create? No