search

pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

`deploy/install.sh` uses a poetry installer which will be deprecated #384

Open ethanjli opened 3 years ago

ethanjli commented 3 years ago

When I ran deploy/install.sh on 2021-06-14, I saw the following message in the terminal output: This installer is deprecated. Poetry versions installed using this script will not be able to use 'self update' command to upgrade to 1.2.0a1 or later. This is because https://github.com/pez-globo/pufferfish-software/blob/006b6af617f2ab5abf5e7d503eaef43be5e22e0f/deploy/scripts/poetry.sh#L17 downloads and uses a get-poetry.py script to install poetry 1.1.6; however, the script is being changed to an install-poetry.py script (this is documented on on the poetry master branch documentation page at https://python-poetry.org/docs/master/ but not on the official poetry v1.1 documentation page at https://python-poetry.org/docs/ ). Once poetry v1.2 is officially released, we may want to change the update script to use the new install script and get poetry v1.2, if only to minimize the number of warnings to ignore from the deploy scripts so that only meaningful warnings/errors are displayed.

ethanjli commented 2 years ago

We should wait until poetry v1.2 is released before doing anything on this.