search

pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

Add backend state segment to report device connection statuses #388

Closed ethanjli closed 3 years ago

ethanjli commented 3 years ago

This PR fixes #371 by adding a new BackendConnections message type in proto/frontend_pb.proto so that the backend's server protocol can report whether the MCU and frontend are currently connected. This PR also updates the frontend's selectors to use this message type.

For records-keeping:

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
  2. Were any of these contributions also part of work you did for an employer or a client? No
  3. Does this work include, or is it based on, any third-party work which you did not create? No
ethanjli commented 3 years ago

@rohanpurohit Can you test this on your end, and also review the code for:

  1. Whether the changes I made to selectors could potentially violate any assumptions you've made in the frontend code you've written using those selectors
  2. Whether this gives you everything you need so that you can work on #361

as well as anything which sticks out to you in code review

rohanpurohit commented 3 years ago
  1. Whether the changes I made to selectors could potentially violate any assumptions you've made in the frontend code you've written using those selectors

Nope! looks good.

  1. Whether this gives you everything you need so that you can work on #361

Yes! I'll start working on it.