pez-globo / pufferfish-software

All software for the Pufferfish ventilator.
Apache License 2.0
0 stars 1 forks source link

Implement Event Synchronization protocol in firmware for early delivery of changed states #406

Closed ethanjli closed 3 years ago

ethanjli commented 3 years ago

This PR is a mostly one-to-one direct port of the backend's implementation of the Event Synchronization protocol from #403, but with some key differences:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 919b607bd4e5287b15127d0fe9157860705c2e46 into 1c94689b27570c4f5227d27e07c05059269bd54a - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging d4b73bf22a566ad4eac3209631a498ffb57ef80d into 1c94689b27570c4f5227d27e07c05059269bd54a - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging a77d64ae70769aabf0eed931c7918c1d3e57115f into 1c94689b27570c4f5227d27e07c05059269bd54a - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 7cef74957616dcf913ffb6b0f5f537ee5d3f02e7 into 1c94689b27570c4f5227d27e07c05059269bd54a - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 1a07edb25d877903c29ca3d00b39e911b8e5b9bc into 1c94689b27570c4f5227d27e07c05059269bd54a - view on LGTM.com

new alerts:

ethanjli commented 3 years ago

For records-keeping:

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
  2. Were any of these contributions also part of work you did for an employer or a client? No
  3. Does this work include, or is it based on, any third-party work which you did not create? Yes: this PR adds the Boost PFR library as a header-only library included in the Core/Inc directory, along with its license file. The PFR library is licensed under the Boost Software License, which is a permissive license and is compatible with our project's licenses. I've recorded the use of this library, along with the license, on our Notion page for tracking third-party works and licenses.
ethanjli commented 3 years ago

@rohanpurohit What level of review and/or testing do you think we should apply to this PR? Do you think we should include this in milestone v0.12, or move it to v0.13?

rohanpurohit commented 3 years ago

@rohanpurohit What level of review and/or testing do you think we should apply to this PR? Do you think we should include this in milestone v0.12, or move it to v0.13?

It looks like I can only do light testing on this one! I assume if we go ahead with #403 we'll need to merge this too? I feel like maybe we can go ahead with it if it looks good to you on your end? sorry about not responding sooner.

ethanjli commented 3 years ago

Great, thanks! I had forgotten to test the alarm muting to get a sense of the latency improvements for that.