(Files changed tab in github is slightly misleading: ValueInfo is now reduced more or less to how LargeValueInfo looked like)
LargeValueInfo was a copy-paste of ValueInfo therefore is now removed/unified with ValueInfo.
ControlValuesDisplay in ValueInfo is modified to accommodate for Large Value components on the dashboard.
ValueInfo is basically reduced to just one component used previously as mainContainer, code for subContainer1 and subContainer2 is removed, The sub-containers in the current code base was only used in PressureControlMainView which in itself is unused, we can modify ValueInfo later and potentially differently to account for those changes (if we need them).
The above change also removes an eslint-disable react/prop-types in ValueInfo where we were passing 3 props in one object.
Selectors:
A selector is added to return AlarmLimits based on the stateKey as an array of numbers, since ValueInfo prop alarmLimits is of type number[]
HFNCGraphView.tsx, MultiStepWizard.tsx:
Changes here are simply how the props should be passed to the ValueInfo component which is now as-is instead of in a mainContainer object
issue 397 - Frontend refactor for dashboard
ValueInfo and ControlInfo are now moved to dashboard/components as they are not containers using the connect from react-redux.
ValueInfo is now simplified
remove updateModalStatus function in ValueInfo and ControlInfo
some parts of the refactor are not covered, mainly providing an alternate component for subcontainers with different layouts (in my opinion, can be done when we need them i.e: different modes).
This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too?
Were any of these contributions also part of work you did for an employer or a client?
Does this work include, or is it based on, any third-party work which you did not create?
Once you test Top-level breadcrumb modal it should be good to merge @ethanjli
This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes.
Were any of these contributions also part of work you did for an employer or a client? No.
Does this work include, or is it based on, any third-party work which you did not create? No.
Issue 404: redraws
(Files changed tab in github is slightly misleading:
ValueInfo
is now reduced more or less to howLargeValueInfo
looked like)LargeValueInfo
was a copy-paste ofValueInfo
therefore is now removed/unified with ValueInfo.ControlValuesDisplay
inValueInfo
is modified to accommodate for Large Value components on the dashboard.ValueInfo
is basically reduced to just one component used previously asmainContainer
, code forsubContainer1
andsubContainer2
is removed, The sub-containers in the current code base was only used inPressureControlMainView
which in itself isunused
, we can modifyValueInfo
later and potentially differently to account for those changes (if we need them).eslint-disable react/prop-types
in ValueInfo where we were passing 3 props in one object.Selectors:
stateKey
as an array of numbers, sinceValueInfo
propalarmLimits
is of typenumber[]
HFNCGraphView.tsx, MultiStepWizard.tsx:
ValueInfo
component which is nowas-is
instead of in amainContainer
objectissue 397 - Frontend refactor for dashboard
ValueInfo
andControlInfo
are now moved todashboard/components
as they are not containers using theconnect
from react-redux.ValueInfo
is now simplifiedupdateModalStatus
function inValueInfo
andControlInfo