Change event type button style in events log

rohanpurohit commented 2 years ago

This fixes #427

rohanpurohit commented 2 years ago

Few issues I see from testing:

AlarmLimits events and control (Ventilation etc) had color as ${theme.palette.primary.main} which is the blue color we have everywhere on frontend, it looks good when the button is filled, but is not quite visible after this PR, which is just a border.
1. we could maybe increase border size from 1px to 2/4px
2. we could change the color (to green or something that's clearly visible)

ethanjli commented 2 years ago

Yes, let's increase the border so it looks thick. 4px would be ideal, unless it interferes with the text or makes the fill region look too thin

rohanpurohit commented 2 years ago

Yes, let's increase the border so it looks thick. 4px would be ideal, unless it interferes with the text or makes the fill region look too thin

I personally like how 4px looks

ethanjli commented 2 years ago

It looks good on the Raspberry Pi with the touchscreen display. I noticed that you've reduced the number of rows per page from 9 to 8, which is fine. Ideally we would have 10 rows per page since that's a nice round number, but since we already weren't at 10 rows per page, I wouldn't consider it a regression of this PR. A future visual improvement might be to adjust padding and margins for the event type button, since they're quite tall now that we've added 8 px of height to each one, but that might make things look visually cramped; a future solution might be to play around more with the styling in other ways so that we can make the things under the "Type" column less tall. I think this PR is fine to merge as it is right now.

For records-keeping:

This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too?
Were any of these contributions also part of work you did for an employer or a client?
Does this work include, or is it based on, any third-party work which you did not create?

rohanpurohit commented 2 years ago

This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes.
Were any of these contributions also part of work you did for an employer or a client? No.
Does this work include, or is it based on, any third-party work which you did not create? No.

pez-globo / pufferfish-software

Change event type button style in events log #432