Closed terricain closed 8 years ago
Wow, seriously impressive stuff. Good job!
One more thing: Consider another commit to add to the copyright (to credit your code) and remove the instructions from the README that suggest setting up a sudoers file.
Good point.
At some point to be 'consistent' we should go through and either add the copyright header to all the files, or remove them and have one main copyright document.
I'd opt for a header on all unattributed files - give credit where it's due - and is transparent should the file be opened when installed to the system.
(By the way, 2015-2016 - you never touched the code during 2015. :wink: )
Few notes:
Successfully connected to dbus service.
" - is this working on your end?All worked on my end. Did you load up the new daemon as well? On 12 Jan 2016 21:27, "Luke Horwell" notifications@github.com wrote:
Few notes:
- Can no longer CTRL+C out of Tray Applet
- Chroma Controller loads a white screen, no error, just "Successfully connected to dbus service. " - is this working on your end?
— Reply to this email directly or view it on GitHub https://github.com/pez2001/razer_blackwidow_chroma_driver/pull/47#issuecomment-171062051 .
Still no go. I uninstalled, rebooted, compiled, packaged then installed... all successful, even cleared old config (in case it was stuck on old profiles) -- Chroma GUI still remains plain white.
Which distro by any chance? Ubuntu MATE 15.10 here.
Can't see why it's not working, but I'll try investigate. :confused:
Ubuntu 14.04 LTS. Will try again once I get back to the computer but am
sure it worked for me. What's ls /usr/lib/python3/dist-packages/razer
list? There should be 2 main python files
On 12 Jan 2016 21:48, "Luke Horwell" notifications@github.com wrote:
Nope, still no go. I uninstalled, rebooted, compiled, packaged then installed... all successful, but the Chroma GUI is still plain white. Which distro by any chance? Ubuntu MATE 15.10 here.
Will try figuring out what's happened... [image: :confused:]
— Reply to this email directly or view it on GitHub https://github.com/pez2001/razer_blackwidow_chroma_driver/pull/47#issuecomment-171068744 .
As expected from the new install:
daemon_dbus.py __init__.py keyboard.py __pycache__
I think it's somewhere around line 404 and 429 where WebKit is added to the Gtk window, but I could be wrong.
404 and 429 of what file? On 12 Jan 2016 21:57, "Luke Horwell" notifications@github.com wrote:
daemon_dbus.py init.py keyboard.py pycache
I think it's somewhere around line 404 ( [image: :smile:] Yes, literally!) and 429, but I could be wrong.
— Reply to this email directly or view it on GitHub https://github.com/pez2001/razer_blackwidow_chroma_driver/pull/47#issuecomment-171072384 .
gui/chroma_controller/chroma_controller.py
Actually, from experimenting - WebKit seems to be all added to Gtk just fine, it's just not loading HTML files for some reason.
Absolutely weird, I git clone
'd the repository instead and by pure magic, it's working again. Must of had something to do with the ZIP download of your repository. Sorry about that.
Ha, no worries. Do you install it using the packaging commands making a .deb?
From the working directory, I execute:
make -s all
./package_for_ubuntu.sh
sudo service razer_bcd stop
sudo dpkg -r razer-chroma-driver
sudo dpkg -i /tmp/tmp*.deb
Some real strange quirks have been going on with this repository, I think one of them was fixed earlier by @pez2001
Edit: May have found the culprit. It runs at /usr/share/razer_chroma_controller/chroma_controller.py
but has a white screen when ran relatively within the repository (./gui/chroma_controller/chroma_controller.py
)
Yeah. Also for the record technically just running
make
./packagefordebian...
dpkg -i razer.dpkg
Should just work as technically it should automatically stop the razer_bcd daemon and replace the currently installed package On 12 Jan 2016 22:27, "Luke Horwell" notifications@github.com wrote:
From the working directory, I execute: make -s all ./package_for_ubuntu.sh sudo service razer_bcd stop sudo dpkg -r razer-chroma-driver sudo dpkg -i /tmp/tmp*.deb
Some real strange quirks have been going on with this repository.
— Reply to this email directly or view it on GitHub https://github.com/pez2001/razer_blackwidow_chroma_driver/pull/47#issuecomment-171080409 .
BOOM - see commits for more details.
Ok what did I do...
Converted the Tray applet to use Python3 as the other GUI is in Python3 I thought I might as well update.
Updated packaging scripts - removed python2 stuff as library isn't 100% compatible.
Added another DBUS endpoint which the daemon interacts with the set_key_row driver file. This allows for us to set colours in userspace. It accepts an array of bytes which are in the format of 1byte for row then 22 1*3 byte RGB values. So total 67 Bytes. If you want to set multiple rows then you can concatenate the byte strings and send any multiple of 67 bytes.
Created a keyboard colour class in python to interact with the new dbus command. This forms the binary array in memory and you can use that to send to DBUS. This class takes in a
key
which is like 'K' or '4' or 'LEFTSHIFT' etc... and a colour value, ideally this class is used for representing the keyboard's colour state in memory.Remvoved globals from the GUI app, reworked it a ton to no longer need root permissions and it now uses DBUS.