search

pezra / exhal

Use HAL APIs with ease
MIT License
22 stars 15 forks source link

Change namespace of task not to collide with other release libraries #70

Closed alakra closed 5 years ago

alakra commented 5 years ago

Summary

Depending on the order of dependency compilation in downstream elixir apps, this release module clashes with libraries like distillery with the mix task mix.release.

Potential Solution

In this PR, I added a ExHal into the namespace to show that it was specific to this library.

heyZeus commented 5 years ago

👍

pezra commented 5 years ago

@anthonyfalzetti, i'm disappointed this was merged without more discussion.

anthonyfalzetti commented 5 years ago

@pezra sorry I thought this was straightforward and I checked that it wasn't being used in other parts of the code. Next time I will wait for discussion before merging in.

alakra commented 5 years ago

@pezra Let's discuss. Things can be reverted if this does not align with your vision.

pezra commented 5 years ago

Not sure I have a vision for this. 🙂 It just seems a little... arbitrary?

Should exhal have a release task at all? If it should, why is distillery's release task higher in the pecking order (ie, why not rename distillery created task)?

We should document the release process, regardless.

Don't revert this. It's definitely good enough to stay in. I just want to sure I'm following along.

On Tue, Apr 23, 2019, 1:01 PM Angelo Lakra notifications@github.com wrote:

@pezra https://github.com/pezra Let's discuss. Things can be reverted if this does not align with your vision.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pezra/exhal/pull/70#issuecomment-485932895, or mute the thread https://github.com/notifications/unsubscribe-auth/AAABAGRPLP5XUJUE2R2EVQDPR5MIPANCNFSM4HH4CUPQ .