This PR includes a number of improvements and fixes to hal-client's specs.
It:
Upgrades rspec to the latest version
Changes specs that were still using an older syntax and/or depended on rspec's monkey patches
Enables auto-require of the spec_helper
Adds the current recommended rspec defaults to spec_helper
Enables ruby warnings during spec execution
Fixes the ruby warnings uncovered
...and bumps hal-client to 3.16.1.
Why? I'm working on a project that makes use of hal-client and where we run our specs with warnings enabled, and I'm looking to fix warnings from our dependencies so we can have a clean spec execution with warnings enabled. The other fixes... I was in the neighbourhood ;)
pezra
commented
8 years ago
This PR includes a number of improvements and fixes to hal-client's specs.
It:
...and bumps hal-client to 3.16.1.
Why? I'm working on a project that makes use of hal-client and where we run our specs with warnings enabled, and I'm looking to fix warnings from our dependencies so we can have a clean spec execution with warnings enabled. The other fixes... I was in the neighbourhood ;)
Thanks for your awesome work on hal-client!