search

pezra / rspec-mode

An RSpec minor mode for Emacs
257 stars 112 forks source link

Check expanded file path for spring pid file also #148

Closed egh closed 8 years ago

egh commented 8 years ago

I am using spring 1.7.2. In that version, at least, the file name of the path in the md5 sum pid file is the full path, not the relative path.

I am not sure if this is always the case, so I have added another check for the spring pid file rather that replace the old one.

dgutov commented 8 years ago

Thanks. But could you find out what version this has changed in? For future reference, at least.

We should also consider removing support for some older versions of Spring. Are there reasons to continue using pre-1.2.0 Spring, for example?

egh commented 8 years ago

Maybe it changed in https://github.com/rails/spring/commit/487a32668f74ac5c64e1124613c700f6752f67d5 ? Or maybe it was always unspecified if it would use an absolute or relative path?

Spring 1.2.0 seems to have been released around Nov 22, 2014. Since spring will only speed up tests if it is running and is not strictly necessary, removing support for old versions seems reasonable.

dgutov commented 8 years ago

Maybe it changed in rails/spring@487a326?

Doesn't look like it: it's a different absolute path.

Or maybe it was always unspecified if it would use an absolute or relative path?

That would be weird, since we never had this complaint before.

Since spring will only speed up tests if it is running and is not strictly necessary, removing support for old versions seems reasonable.

As long as we want to continue supporting old versions of Rails (and we probably do), I think this depends on which version of Spring supports e.g. Rails 3.2. The latest one doesn't.

egh commented 8 years ago

Ugh, I think the problem was in my init.el. It appears that spring has always used a full path to generate the PID file name. The problem was that I have overidden my rspec-project-root directory to look for the vc-git-root. The issue is that vc-git-root does not necessarily return an expanded path. (In a project that I work on, there are multiple Rakefiles that are present in non-root directories, so rspec-project-root was not working.)

Thanks for your help with this, and sorry to have wasted your time!