Closed dunn closed 8 years ago
Hey, thanks for doing this! It seems we should set up Travis integration as well (not necessarily as a part of this PR).
Any particular reasons for changing pendings' error type?
A test was added that specified that pending
should be type Info in https://github.com/pezra/rspec-mode/commit/6e6fb6cee347f291e520c55bb87888a5bba254c3, so I was just following that. But I didn't realize you changed them to warnings in https://github.com/pezra/rspec-mode/commit/33ac5b1fc928ccbce6837af683c653421bd14b7a.
So I thought the spec was right and the code was wrong, but maybe it's the other way around?
but maybe it's the other way around?
Probably, yes. Without the CI set up, I've promptly forgot that we now have tests.
Sounds good! Updated the test to match the existing code.
Thanks!
I was getting failures running the test suite; these are the changes I made to get things going again:
rspec-compilation-error-regexp-alist-alist
; now they're info.rspec--test-compilation-match-p
cl-lib
required by the tests,some
was undefined.I went ahead and disambiguated
cl-some
, and added a make target.