pezra / rspec-mode

An RSpec minor mode for Emacs
257 stars 112 forks source link

Get tests passing #149

Closed dunn closed 8 years ago

dunn commented 8 years ago

I was getting failures running the test suite; these are the changes I made to get things going again:

I went ahead and disambiguated cl-some, and added a make target.

dgutov commented 8 years ago

Hey, thanks for doing this! It seems we should set up Travis integration as well (not necessarily as a part of this PR).

Any particular reasons for changing pendings' error type?

dunn commented 8 years ago

A test was added that specified that pending should be type Info in https://github.com/pezra/rspec-mode/commit/6e6fb6cee347f291e520c55bb87888a5bba254c3, so I was just following that. But I didn't realize you changed them to warnings in https://github.com/pezra/rspec-mode/commit/33ac5b1fc928ccbce6837af683c653421bd14b7a.

So I thought the spec was right and the code was wrong, but maybe it's the other way around?

dgutov commented 8 years ago

but maybe it's the other way around?

Probably, yes. Without the CI set up, I've promptly forgot that we now have tests.

dunn commented 8 years ago

Sounds good! Updated the test to match the existing code.

dgutov commented 8 years ago

Thanks!