search

pezra / rspec-mode

An RSpec minor mode for Emacs
257 stars 112 forks source link

Added support for running rspec in docker container #153

Closed micdahl closed 7 years ago

micdahl commented 7 years ago

I am no Lisp programmer, so somebody with more experience should have a look. Also my code could effect the vagrant support, I have not tested this.

I have tested the docker support for rspec with Emacs 25.1.1 running on Windows 10. To use it, rspec-use-docker-when-possible has to be t, rspec-docker-container must be the name of the running container and rspec-docker-cwd should name the directory of the rails application inside of the docker container.

pezra commented 7 years ago

An rspec-docker-command setting works for me. I did not realize that docker compose had that limitation on windows.

dgutov commented 7 years ago

Considering the command template (in rspec--docker-wrapper) hasn't changed, is there a point in using docker compose?

Sorry if the question is naive, I don't use Docker.

micdahl commented 7 years ago

Considering the command template (in rspec--docker-wrapper) hasn't changed, is there a point in using docker compose?

Docker containers which belong to the project get started automatically when using docker compose. If you are using one docker container for the ruby environment and an other one for a database for example, the containers can be configured through docker compose. When you run a command in one container through docker-compose run, dependent containers get started by docker compose automatically. Precondition is, that a docker compose configuration for the project exists. If you execute a command through docker exec , dependent containers have to be started and connected manually before.