search

pezra / rspec-mode

An RSpec minor mode for Emacs
257 stars 112 forks source link

Fix target directory bug #176

Closed Jell closed 5 years ago

Jell commented 6 years ago

Problem

Running rspec-verify-continue appends the current directory to the relative directory of the file it is run from

Reproduce

Open spec/models/foo_spec.rb M-x rspec-verify-continue

It will try to run rspec /user/me/project/spec/models/spec/models/foo_spec.rb

Cause and solution

dynamic scoping and closure not playing well, avoid shadowing of variables to resolve

dgutov commented 6 years ago

Is that related to #174?

Jell commented 6 years ago

from a quick glance, I don’t think so? this issue is not about path expansion but about using the wrong project root dir

kzkn commented 6 years ago

Maybe they are the same issue. rspec-verify-continue runs successfully with applying #174 patch.

dgutov commented 5 years ago

@Jell I've merged the other PR. Please see if the problem remains.

Jell commented 5 years ago

that actually did the trick! thanks @dgutov