search

pezra / rspec-mode

An RSpec minor mode for Emacs
257 stars 112 forks source link

Reprioritise project-relative paths #215

Closed johnhamelink closed 1 year ago

johnhamelink commented 1 year ago

Currently, rspec-use-relative-path is not respected for remote/container/vagrant files.

This change ensures that relative paths are passed through to RSpec, even if the target is remote:

-*- mode: rspec-compilation; default-directory: "/sshx:john@dest:~/code/work/rails/" -*-
RSpec Compilation started at Thu Aug 17 19:26:52

podman-compose -f ../dev/docker-compose.yml exec rails sh -c "bundle exec rake spec SPEC_OPTS='--options .rspec' SPEC='spec/'"
dgutov commented 1 year ago

Okay, let's try that, thanks.

The question of using both a relative path and Vagrant came up in the original PR (https://github.com/pezra/rspec-mode/pull/177), but nobody criticized the current implementation, for some reason or other.