search

pezzolabs / pezzo

🕹ī¸ Open-source, developer-first LLMOps platform designed to streamline prompt design, version management, instant delivery, collaboration, troubleshooting, observability and more.
https://pezzo.ai
Apache License 2.0
2.55k stars 211 forks source link

feat: warp non-antd icons with `<Icon/>` #206

Closed Robbevdv13 closed 1 year ago

Robbevdv13 commented 1 year ago

Fixes #203

Everywhere the @heroicons import was used, I wrapped the non-antd icons with the Icon tag, as demonstrated in the issue. Issue: https://github.com/pezzolabs/pezzo/issues/203

I did have some troubles running the project, so I was not able to check if the width of the icons was fitting: The error:

Screenshot 2023-09-18 at 20 58 46
arielweinberger commented 1 year ago

Hi @Robbevdv13 that was fast! I'll take a look and make sure everything looks good. Will keep you posted. Do you mind commenting on the issue? This way I can assign it to you.

In the meantime, will you be able to ping me on Discord? It would be good if we could debug the issue you're facing with running the project, to make sure it won't happen to others.

arielweinberger commented 1 year ago

Also, please fix formatting by running the following at the root of the repo:

npx nx format:write --all

Then, commit the changes. CI should then pass :)

arielweinberger commented 1 year ago

@Robbevdv13 Are you planning to address the CI issue?

Robbevdv13 commented 1 year ago

@Robbevdv13 Are you planning to address the CI issue?

Yes I just formatted the code. I will contact you on discord to troubleshoot the issue I described at the beginning of our conversation

nx-cloud[bot] commented 1 year ago

☁ī¸ Nx Cloud Report

CI is running/has finished running commands for commit 7bc21e36e3d925bae0c116c88ff28b12b6a67124. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 3 targets - [`nx graphql:codegen:offline server`](https://cloud.nx.app/runs/RznBhu5tkO) - [`nx run-many --target=test --all --parallel --maxParallel=3`](https://cloud.nx.app/runs/sG0IvvKM45) - [`nx run-many --target=lint --all --parallel --maxParallel=3`](https://cloud.nx.app/runs/P1faF9DYMt)

Sent with 💌 from NxCloud.

arielweinberger commented 1 year ago

CI looks good. I'll clone the code a bit later to check he changes visually.

arielweinberger commented 1 year ago

I've pushed some visual fixes to make the icons look nicer (mostly on the sidebar). Well done, thank you for your contribution! If you find the time, please ping me on Discord so we could figure out why you can't run the platform. Maybe I could even help you create a PR for that.

p.s. congrats on being our first Hacktoberfest-approved PR!