pezzolabs / pezzo

🕹️ Open-source, developer-first LLMOps platform designed to streamline prompt design, version management, instant delivery, collaboration, troubleshooting, observability and more.
https://pezzo.ai
Apache License 2.0
1.94k stars 177 forks source link

feat: allows merging pezzo options with openai options #270

Closed lh0x00 closed 7 months ago

lh0x00 commented 7 months ago

Being able to only use one of the two is a limitation, and I encountered the fact that if I used pezzo's variables I couldn't add headers to the request, so I suggested updating it.

Please take a look and merge if it's ok.

lh0x00 commented 7 months ago

@arielweinberger thanks for review

arielweinberger commented 7 months ago

I understand the need - thanks for the PR @lh0x00. I was thinking to move the OpenAI options to the 3rd argument rather than the 2nd, so no merging, just because some of the parameter names used in Pezzo such as properties, variables and cache could potentially create conflicts with future parameters introduced by OpenAI. Thoughts?

lh0x00 commented 7 months ago

@arielweinberger I agree with this, and I will update it.

lh0x00 commented 7 months ago

hi @arielweinberger do you need me to update anything else? because I'm waiting for its release to use directly instead of a fork of pezzo. If possible, please help me review it as soon as possible, thank you.

arielweinberger commented 7 months ago

@lh0x00 Will merge ASAP. Can you fix formatting? npx nx format:write --all

lh0x00 commented 7 months ago

@arielweinberger I have updated it again, thanks for review.

arielweinberger commented 7 months ago

Please make the 3rd argument optional (and handle the case in which it is undefined). CI fails.

lh0x00 commented 7 months ago

I updated it.

arielweinberger commented 7 months ago

This should be alright @lh0x00 I'll run some tests and if all is good I'll push and release.

arielweinberger commented 7 months ago

@lh0x00 should be live at @pezzo/client@0.4.18

lh0x00 commented 7 months ago

thank you so much, @arielweinberger