Closed lh0x00 closed 7 months ago
@arielweinberger thanks for review
I understand the need - thanks for the PR @lh0x00. I was thinking to move the OpenAI options to the 3rd argument rather than the 2nd, so no merging, just because some of the parameter names used in Pezzo such as properties
, variables
and cache
could potentially create conflicts with future parameters introduced by OpenAI. Thoughts?
@arielweinberger I agree with this, and I will update it.
hi @arielweinberger do you need me to update anything else? because I'm waiting for its release to use directly instead of a fork of pezzo. If possible, please help me review it as soon as possible, thank you.
@lh0x00 Will merge ASAP. Can you fix formatting? npx nx format:write --all
@arielweinberger I have updated it again, thanks for review.
Please make the 3rd argument optional (and handle the case in which it is undefined). CI fails.
I updated it.
This should be alright @lh0x00 I'll run some tests and if all is good I'll push and release.
@lh0x00 should be live at @pezzo/client@0.4.18
thank you so much, @arielweinberger
Being able to only use one of the two is a limitation, and I encountered the fact that if I used pezzo's
variables
I couldn't addheaders
to the request, so I suggested updating it.Please take a look and merge if it's ok.