search

pf-wikis / mapping

https://map.pathfinderwiki.com
20 stars 5 forks source link

Buildings and districts layers are rendered under the hills layer #289

Open oznogon opened 1 month ago

oznogon commented 1 month ago

Rendering pf-wikis/mapping-data/pull/51 results in Kaer Maga's city features, specifically the districts and buildings layers, not rendering.

In QGIS:

image

Rendered:

image

oznogon commented 1 month ago

This doesn't appear to affect Port Peril, though, so I'm not sure what's actually happening in the Kaer Maga PR.

image

manuel-hegner commented 1 month ago

Mhh, interesting. I will investigate this after I am done with the current rework of the processing pipeline. I merge https://github.com/pf-wikis/mapping-data/pull/51 for now, as I think the data changes are correct. The bug should be somewhere in the code here.

manuel-hegner commented 1 month ago

I think the districts layer is indeed rendered underneath the hill layer, while the the buildings layer was just not rendered on your tests because of precision limitations. Features, that are too small, are cut from the map, so buildings might not show up in the default settings. For hills, this is a bit difficult. Sometime small hills should be visible in cities (e.g. Magnimar). Maybe the style for districts is just a bad choice. Maybe they need to be rendered transparently or just with outlines.

oznogon commented 1 month ago

I think the districts layer is indeed rendered underneath the hill layer, while the the buildings layer was just not rendered on your tests because of precision limitations. Features, that are too small, are cut from the map, so buildings might not show up in the default settings.

Looks like that's the case. I rendered to -z12 but it looks like the published map's been using -z13 since June.

For hills, this is a bit difficult. Sometime small hills should be visible in cities (e.g. Magnimar). Maybe the style for districts is just a bad choice. Maybe they need to be rendered transparently or just with outlines.

If I have a vote in that, I'd suggest rendering the shading just above the land layer and also as a duplicate outline layer with transparency above hills/mountains similar to the borders layers. That might also make it a little easier to scale only the district border line widths by zoom level.