search

pf4j / pf4j-update

Update mechanism for PF4J
Apache License 2.0
69 stars 39 forks source link

New test for install, update, delete #15

Closed janhoy closed 7 years ago

janhoy commented 7 years ago

Applies on top of https://github.com/decebals/pf4j-update/pull/14

janhoy commented 7 years ago

Ok, currently this test uses the real (SNAPSHOT-version) DefaultPluginManager and won't work without it. I tried a very simple Mock of DefaultPluginManager to isolate test to pf4j-update only, but since it has a lot of state, that was not so easy. Could go for EasyMock or something but have no time now. If pf4j-update gets converted to a maven sub module of pf4j, then these tests will pass...

Or start thinking about release pf4j-1.3.0

decebals commented 7 years ago

Don't waste your time to create a mock for PluginManager only to pass the tests. I can release a new version of PF4J if you think that the actual code is OK for your tests. The other variant is to bring the pf4j-update project as a module in the PF4J project. My only concern is how to mange the whole documentation because, to put everything in the readme file I think that it'is a little bit to much (a possible solution is to use the wiki from GitHub).

janhoy commented 7 years ago

No worries, I have similar tests passing here in my app, so this PR can wait until the next release. You are free to decide when do do a new release, I am in no hurry :-)

Re. documentation, perhaps a multi page Wiki would be good, and keep the README very short.

decebals commented 7 years ago

I don't know if I can move pf4j-update project as a folder (pf4j-update, a Maven module) in PF4J project without to lose the git content (commits, ...). For the moment I will release a new SNAPSHOT version of PF4J and I will make pf4j-update to use this version.