search

pf4j / pf4j-update

Update mechanism for PF4J
Apache License 2.0
69 stars 39 forks source link

Please consider introducing a unit-testing framework #41

Closed hazemkmammu closed 5 years ago

hazemkmammu commented 5 years ago

It would make it a lot easy for the community to contribute to the project without worrying too much about introducing new bugs. I can create a PR if you don't mind.

decebals commented 5 years ago

JUnit and Mockito are already available in pom.xml, as dependencies. What other framework you want to introduce?

hazemkmammu commented 5 years ago

My apologies. I only looked at the classes org.pf4j.update.RepositoriesTest and org.pf4j.update.UpdateTest which had a main method with test calls.

decebals commented 5 years ago

@hazemkmammu I understand. Yes, they are not unit tests. I think that in the end we can transform/convert them in unit tests.