pf4j / pf4j-update

Update mechanism for PF4J
Apache License 2.0
69 stars 39 forks source link

refactor integration tests to run as part of build #47

Closed robzienert closed 4 years ago

robzienert commented 4 years ago

The UpdateTest and similar classes in the test source set don't actually run as part of a build. This PR refactors things around a little bit so they actually run.

Other changes:

After doing all of this, it looks like all of the tests pass. Kind of unfortunate, because that means our integration with pf4j-update likely has a bug in it. 😆

decebals commented 4 years ago

It looks OK. Thanks!

decebals commented 4 years ago

The UpdateTest and similar classes in the test source set don't actually run as part of a build.

The UpdateTest is not a real test. Actually, it's a kind of demo about how to use pf4j-update in a pf4j based application. Probably the test directory is not the best location for this file but I didn't find a better option. After this PR, we have a broken link in readme file but I think that we can fix it relative easy.

robzienert commented 4 years ago

I'm not a maven guy by any means, but maven supports multi-project builds right? There could be the actual pf4j-update module and then an example module which has a compile dependency on the pf4j-update module?