org.slf4j:slf4j-log4j12 should have scope compile in pom.xml

pf4j / pf4j-update

Update mechanism for PF4J

Apache License 2.0

69 stars 39 forks source link

org.slf4j:slf4j-log4j12 should have scope compile in pom.xml #56

Closed pgrt closed 3 years ago

pgrt commented 3 years ago

Hello,

In pom.xml, the <scope>test</scope> of org.slf4j:slf4j-log4j12 should be removed, as classes of slf4j are needed by classes of pf4j-update in src/main/ .

Best, Pierre Gruet

decebals commented 3 years ago

In src/main is enough slf4j-api that is transitive dependency from pf4j.

pgrt commented 3 years ago

Hello,

Oh right, thanks for pointing this out!

Best, Pierre