search

pfadfinder-konstanz / hugo-dpsg

Hugo theme based on the DPSG theme for German scout websites. Forked from the Mainroad theme
GNU General Public License v2.0
30 stars 15 forks source link

Menu Item Font - Serif? #4

Closed m9aertner closed 3 years ago

m9aertner commented 3 years ago

Is it intentional that the Menu Items appear in a serif font when the site default is sans serif?

Please consider themes\hugo-dpsg\assets\css\style.css # .menu__link:

I would expect that a theme does not mix serif and sans-serif. I realize that custom CSS files can be configured to override this, and you of course might simply find the current look much better, but from a (non-professional) design point of view I believe the default should be consistent across the whole page, i.e. non-serif.

Feel free to close this issue if that choice was intentional. Also, I did not check the underlying WordPress theme, maybe that's just a setting that was taken over from there faithfully. Otherwise, just deleting CSS line 633 is what I would recommend.

I really appreciate you making your work available publicly. Thanks! M.

mxmehl commented 3 years ago

Yes, it's intentional in a sense that the same fonts are used on dpsg.de. The headlines in my theme differ a bit (sans instead of serif), but mixing these seemed even less logical to me.

I really appreciate you making your work available publicly. Thanks!

Thank you, and thanks for reporting this issue :)