pfalcon / ScratchABit

Easily retargetable and hackable interactive disassembler with IDAPython-compatible plugin API
GNU General Public License v3.0
393 stars 47 forks source link

Various little cleanups; idapython comment API #22

Closed neuschaefer closed 7 years ago

neuschaefer commented 7 years ago

Hi, this patch set is mostly cosmetics, but also one functional change: I implemented get_cmt/set_cmt so disassembler plugins can manipulate comments in the disassembly.

Please review, thanks.

pfalcon commented 7 years ago

Thanks for the pull request. Few quick generic comments: a) in the future, please avoid putting unrelated patches in one PR; b) please follow existing pattern for commit messages, it can be easily discerned from git log: https://github.com/pfalcon/ScratchABit/commits/master

neuschaefer commented 7 years ago

Thanks for the pull request. Few quick generic comments: a) in the future, please avoid putting unrelated patches in one PR;

Ok

b) please follow existing pattern for commit messages, it can be easily discerned from git log: https://github.com/pfalcon/ScratchABit/commits/master

Ok, I'll update the commits to follow this pattern.

pfalcon commented 7 years ago

Thanks, all is merged. But for reference, "engine: save_addr_props: fix for loop indentation" and "curses: Remove directory" are maintainer-level changes. In this case, these changes were per the plan (somewhat backlogged/forgotten plan), but I may be reluctant to apply similar changes if they "unexpected", with the argument e.g. that they introduce git blame noise ;-). So, it's recommended to discuss similar changes in the future.

neuschaefer commented 7 years ago

[...] So, it's recommended to discuss similar changes in the future.

Ok, fair comments. I'll consider it in the future.