Closed neuschaefer closed 7 years ago
Thanks for the pull request. Few quick generic comments: a) in the future, please avoid putting unrelated patches in one PR; b) please follow existing pattern for commit messages, it can be easily discerned from git log: https://github.com/pfalcon/ScratchABit/commits/master
Thanks for the pull request. Few quick generic comments: a) in the future, please avoid putting unrelated patches in one PR;
Ok
b) please follow existing pattern for commit messages, it can be easily discerned from git log: https://github.com/pfalcon/ScratchABit/commits/master
Ok, I'll update the commits to follow this pattern.
Thanks, all is merged. But for reference, "engine: save_addr_props: fix for loop indentation" and "curses: Remove directory" are maintainer-level changes. In this case, these changes were per the plan (somewhat backlogged/forgotten plan), but I may be reluctant to apply similar changes if they "unexpected", with the argument e.g. that they introduce git blame noise ;-). So, it's recommended to discuss similar changes in the future.
[...] So, it's recommended to discuss similar changes in the future.
Ok, fair comments. I'll consider it in the future.
Hi, this patch set is mostly cosmetics, but also one functional change: I implemented
get_cmt
/set_cmt
so disassembler plugins can manipulate comments in the disassembly.Please review, thanks.