RFC: Split current core.py

pfalcon / ScratchABlock

Yet another crippled decompiler project

https://github.com/EiNSTeiN-/decompiler/issues/9#issuecomment-103221200

GNU General Public License v3.0

102 stars 23 forks source link

RFC: Split current core.py #17

Open pfalcon opened 6 years ago

pfalcon commented 6 years ago

The problem is that it contains 2 different kinds of classes:

"Atomic"/"Simple", e.g. REG, ADDR
"Complex"/"Recursive", e.g. EXPR, Inst

Simple types are oftentimes imported by other modules. And complex types sometimes need services of these other modules, leading to circular imports which need to be worked around.

maximumspatium commented 6 years ago

What about creating a package named "core"? It could contain different modules grouped together according to function...

pfalcon commented 5 years ago

Ok, instead of splitting core.py, I instead split xform.py. Now there're:

xform_bblock.py xform_cfg.py xform_expr_infer.py xform_expr.py xform_graph.py xform_inst.py xform_inter.py

Those clear call to be moved to package (xform.cfg, etc.), but I'm not doing that so far for pure practical reasons of not jumping between dirs when editing code.