search

pfalcon / esp-open-sdk

Free and open (as much as possible) integrated SDK for ESP8266/ESP8285 chips
1.97k stars 624 forks source link

Updating esptool to v2.2 #299

Open ckerkhoff opened 6 years ago

pfalcon commented 6 years ago

Yes, but why?

nochkin commented 6 years ago

I can't say for the author of the PR, but I use the latest esptool for various reasons.

Here are the most significant ones for me:

  1. The best feature I like about it is the ability to compress firmware file before uploading so it speeds up the flash process.

  2. The new esptool version works with both python 2 and 3 as well, while the old one is not compatible with python 3.

  3. Also, I had some issues with the bundled with esp-open-sdk version is that sometimes (although, not often) it may not detect the device properly and fail because of time out so I just need to start again. Could be something locally on my side, but the newer version of esptool resolved it and I never seen this issue since the update.

Maybe there are other things which I don't remember, but at least I don't regret since I updated it a few months ago. If we would vote for each PR, I would definitely vote for this one.

ckerkhoff commented 6 years ago

@pfalcon, I figured you may have not noticed the updates. In addition to what @nochkin mentioned, there is the added ability to encrypt firmware for ESP32 chips.

pfalcon commented 6 years ago

I figured you may have not noticed the updates

No worries, I'm github-watching esptool project, so I noticed not just that there're esp32-specific changes there (which aren't needed for this project, which is dedicated to esp82xx), but also noticed reports that newer esptool doesn't work well with some boards, with which older esptool worked well.

Thanks for the patch though, and @nochkin for arguments to apply. I'll need to test this patch to see if I spot any regressions with hardware I have. I apologize in advance if it takes some time.

mcauser commented 6 years ago

Support for 16MB ESP8266 boards, such as the Wemos D1 Mini Pro. https://github.com/espressif/esptool/commit/d2f3567069af5c52fd2f04b7cd1c4bdea85faffa

kriegste commented 6 years ago

The one integrated in esp-open-sdk is the only one working here. I tried several 2.x, but those all fail with a timeout at 53% every time, both at slow and fast baud rates. So I vote for keeping the old version.

Edit: Yes, I have installed proper power supply and capacitance.

nochkin commented 6 years ago

@kriegste, I have many ESP8266-based boards and all work fine with the new tool. I wonder what board you have and what rates did you try (just saying "slow and fast" does not give any clues as it has more options than that). I use it with CP210x and CH340 converters.

P.S.: there is no need to install an extra power supply and capacitance unless I don't know what you are talking about.