search

pfalcon / esp-open-sdk

Free and open (as much as possible) integrated SDK for ESP8266/ESP8285 chips
1.97k stars 623 forks source link

Add support for 2.2.1 NONOS SDK #332

Open maximevince opened 6 years ago

maximevince commented 6 years ago

Simply added support for 2.2.1 NONOS SDK

pfalcon commented 5 years ago

Thanks for the patch! Let me refer to https://github.com/pfalcon/esp-open-sdk/pull/344#issuecomment-437567327 for why there was no response to this PR.

Reviewing it now, I guess I would be interested to merge https://github.com/pfalcon/esp-open-sdk/pull/332/commits/d01c0e5a26be5e2c532fc3b52b9e95d3a76c3d4c commit of it (based on all the feedback with problems building language bindings).

CT_GDB_CROSS_PYTHON=n
CT_GDB_CROSS_EXTRA_CONFIG_ARRAY="--with-guile=guile-2.0"

However, what's the reason for exactly this flag: "--with-guile=guile-2.0"? Did you consider to disable guile binding at all, like you did with the python one?