search

pfalcon / pycopy-lib

Standard library of the Pycopy project, minimalist and light-weight Python language implementation
https://github.com/pfalcon/pycopy
Other
246 stars 70 forks source link

urequests: remove magic constant #41

Closed pulkin closed 4 years ago

pulkin commented 4 years ago

Fix for non-zero AF_INET

pfalcon commented 4 years ago

Thanks for the patch, but it's not correct. 0 is not a (too dark a) magic constant. It's a documented default value for a parameter with defined meeting: https://docs.python.org/3/library/socket.html#socket.getaddrinfo .