search

pfalcon / pycopy-lib

Standard library of the Pycopy project, minimalist and light-weight Python language implementation
https://github.com/pfalcon/pycopy
Other
246 stars 70 forks source link

WIP: A lot of additions and bug fixes #64

Open smurfix opened 3 years ago

smurfix commented 3 years ago

The commits in this series are more-or-less standalone, but I didn't exactly feel like submitting 30 PRs.

These changes are either small(ish) bug fixes, or are necessary to more-or-less-seamlessly support (my MicroPython-ized fork of) Trio as a structured alternative to [u]asyncio.

NB: yes I know that many commit messages ignore the contributor guidelines. I'll fix those (and others) soon.

pfalcon commented 3 years ago

Thanks, this looks impressive, but...

The commits in this series are more-or-less standalone, but I didn't exactly feel like submitting 30 PRs.

... such big codedrops really don't scale and aren't sustainable. If you're interested in contributing, I'd suggest to start with a few patches, and work out contribution process suitable for us both. That indeed includes following contribution guidelines, having tests, and in general, having common vision where that all leads us.

Note that recently, I try to use following approach: keep "native Pycopy" approach (generic small, unbloated code) in separate namespace (just the same as Pycopy builtin modules), and port CPython stdlib modules for all their bloated glory otherwise (and thus suitable for existing CPython software, and reusing existing CPython tests). Of course, CPython's modules still require some patching (and some tests skipping), but it's more sustainable approach than reimplementing everything from scratch. (Only things which worth being minimal are reimplemented from scratch.)