search

pfalcon / uzlib

Radically unbloated DEFLATE/zlib/gzip compression/decompression library. Can decompress any gzip/zlib data, and offers simplified compressor which produces gzip-compatible output, while requiring much less resources (and providing less compression ratio of course).
Other
303 stars 82 forks source link

Rename test files to work for Windows builds #28

Closed earlephilhower closed 4 years ago

earlephilhower commented 4 years ago

Windows doesn't like :s in its filenames, so replace them with underscores and update the expected test outputs accordingly.

pfalcon commented 4 years ago

Thanks for the patch, but: 233 changed files O_o. I'm not sure I love Windows that much ;-).

earlephilhower commented 4 years ago

True, but it's nothing more than a scripted git mv to rename them from : to _s.

Don't get me wrong, it's not like I love Windows that much, either On the ESP8266 code we do builds for Linux X64, OSX, LinuxARM, and Windows as part of CI and git just completely barfs on Win32 when it gets a file with a : in it.

pfalcon commented 4 years ago

Yeah, I understand, it's just I do my homework to maintain clean project history and avoid sweeping changes, so it's a bit hard to swallow contributions like this ;-). Again, let me take some time to come to peace with it ;-). Perhaps, make a repo rebase? :-D (These files were contributed either, and I took them as is.)

d-a-v commented 4 years ago

I'd suggest to just tar-gzip9-all-of-them into a single one file for everyone's peace ;)

earlephilhower commented 4 years ago

For this one, I'm fine dropping it. If #27 merges here, it may be worth patching the ESP8266 CI to just not pull the uzlib submodule or something, but for now we can continue with the forked version.

Thanks again!

pfalcon commented 4 years ago

I actually was looking for a feedback regarding squash-rebase proposal (I myself fully ok with it, but would like to hear what downstream users might say...). Well, I assume it's easier to leave it as is for now...