pfefferf / ui5-nwabap-deployer

UI5 Deployer for SAP NetWeaver ABAP
Apache License 2.0
55 stars 18 forks source link

Add resolve with oFileStoreOptions #39

Closed timia2109 closed 3 years ago

timia2109 commented 3 years ago

Hi,

this PR returns the oFileStoreOptions on resolve. This can be useful, to access the real transport number (for example in other scripts)

Thanks!

pfefferf commented 3 years ago

If a return of the values is done, it should be done in a more extendible way instead of just returning the plain fileStoreOptions object. Values should be returned in a an return object which is extensible, e.g. resolve({ fileStoreOptions: oFileStoreOptions }) So in future additional values can be returned without breaking the interface.

But I would be interested for which concrete cases you would need that now?

timia2109 commented 3 years ago

I've changed it.

So my use case is, to use that Library in a ci/cd script, which should send a notification with the transport request to the user.

pfefferf commented 3 years ago

@timia2109 Thx. Merged + some lint issues fixed. v1.0.18 released.