No error for unlocked resources and invalid transport

pfefferf / ui5-nwabap-deployer

UI5 Deployer for SAP NetWeaver ABAP

Apache License 2.0

55 stars 18 forks source link

No error for unlocked resources and invalid transport #54

Closed Fjaoos closed 3 years ago

Fjaoos commented 3 years ago

Hi,

I am very sorry to bother you again but I expected the plugin to report an error, if the resources of the application have not been locked on a transport already while create_transport = false and transport_use_user_match= false.

https://github.com/pfefferf/ui5-nwabap-deployer/blob/20c6be93d4385c4d9a626573e6ccaa235d0729f5/packages/ui5-nwabap-deployer-core/lib/ui5-nwabap-deployer-core.js#L299

In my use case, the developer has to specify a certain transport from the system and the transports cannot be created by the plugin.

I think this might be because of "&& oOptionsAdapted.conn.testMode !== true". If this code would be added to the following if and elseif, my case would be working.

Thanks in advance fjaoos

pfefferf commented 3 years ago

Please explain it more clearly: Expecting an error, wehn resources are not locked on a transport? Somehow not clear to me why that should be.

Fjaoos commented 3 years ago

Let's say that I want to deploy an application to a system which does not have any unreleased transports and with create_transport = false. In this scenario the resources of the application would not be locked on any open transport but the plugin is not allowed to create a transport for the resources.

pfefferf commented 3 years ago

Thx for the explanation. Got it. My inital thoughts on "disabling" the "create transport" option in test mode - and all related checks - was some kind of "not though enough" :-)

Fixed with v2.2.2 in the core package.

Fjaoos commented 3 years ago

Thank you for the fix but what happens, with these conditions:

running in Testmode
transportUseUserMatch = false
createTransport = false
transportUseLocked = false
oOptionsAdapted.ui5.transportno = COTK910152
sExistingTransportNo = undefined (Because there is no available transport on the system for the ressources yet)

This leads to a successful build run although it should say: The given transport is not available on the system, the resources are not locked on any transport and the creation of a new transport is not allowed. The resources cannot be deployed

pfefferf commented 3 years ago

This will not be checked by the backend service. So it will not be reported. If you have an issue with that, please open an incident for SAP.

Fjaoos commented 3 years ago

Thanks, I will do that.