search

pfefferle / wordpress-semantic-linkbacks

More meaningfull linkbacks
https://wordpress.org/plugins/semantic-linkbacks
MIT License
31 stars 18 forks source link

Some Improvements to Duplicate Strings and Splitting avatar Code #189

Closed dshanske closed 6 years ago

dshanske commented 6 years ago

I need to fix the tests, but @pfefferle does this satisfy the attempt to remove the extra strings?

pfefferle commented 6 years ago

LGTM! I like the encapulation of the avatar feature!

pfefferle commented 6 years ago

One thing: Can you change the avatar filename to includes/class-linkbacks-avatar-handler.php to be consistent?

dshanske commented 6 years ago

Will do when I fix the test I broke. More I want to do in future, but I want to get this released first.

dshanske commented 6 years ago

@pfefferle I think this is ready to go. I really want to look at the templating code for refactoring at some point. @snarfed put the code that checks if this is a reacji into the Comment Walker, and calls it from outside of there in the comment template. I think it might be better off if that code was elsewhere, possibly setting reacji as a type.

dshanske commented 6 years ago

@pfefferle Ready for a new release then, you think?

pfefferle commented 6 years ago

Sure!