pfefferle / wordpress-semantic-linkbacks

More meaningfull linkbacks
https://wordpress.org/plugins/semantic-linkbacks
MIT License
31 stars 18 forks source link

HTML5 comments seems to overwrite facepiles #227

Closed pfefferle closed 4 years ago

pfefferle commented 5 years ago

@dshanske it seems that the html5 implementation (https://github.com/pfefferle/wordpress-semantic-linkbacks/blob/master/includes/class-linkbacks-walker-comment.php#L77) in the comment walker is disabling the facepile feature in some way.

Conversation: https://wordpress.org/support/topic/unable-to-show-facepile/

prtksxna commented 5 years ago

So I installed https://github.com/pfefferle/Autonomie on my site and tested it, and I still don’t get a facepile: https://imgur.com/a/n3F7aJV (my theme on this page )

Also, I double-checked, I am on version 3.9.3 of this plugin.

pfefferle commented 5 years ago

@prtksxna if you checked other themes, it seems not what I thought.

pfefferle commented 5 years ago

@prtksxna can you please send me a picture of your settings?

dshanske commented 5 years ago

I will have a look at this when I can to see if I see something. I haven't been in this code in ages.

prtksxna commented 5 years ago

@pfefferle Here you go:

wpsettings

Let me know if you'd like to see any other setting/page too.

chrismaverick commented 5 years ago

Was this ever worked out? I am having identical symptoms to @prtksxna. Same basic settings. Jetpack commenting turned off as instructed. http://voxpopcast.com/wp/2019/08/26/e72-the-power-of-cuteness/ is a sample page. likes, reposts, etc are showing up as comments. No facepile section is being generated at all.

chrismaverick commented 5 years ago

Also, my understanding is that the webmentions comments that are being generated should probably have user's twitter and instagram avatars on that page, but they're just defaulting to the nobody shadow.

dshanske commented 5 years ago

I have not been able to reproduce this, but I have scheduled a rewrite of this code as part of an overall improvement to webmentions.

chrismaverick commented 5 years ago

since it's not clear if the others are paying attention anymore, If you need a crash test dummy, let me know.

prtksxna commented 4 years ago

Hey o/ Any updates on this? I recently updated the plugin but still get the same issue.

prtksxna commented 4 years ago

This can be closed now that #240 is fixed.