pfefferle / wordpress-webmention

A Webmention plugin for WordPress
https://wordpress.org/plugins/webmention/
MIT License
116 stars 31 forks source link

Should mentions be tied to pings_open? #222

Open dshanske opened 5 years ago

dshanske commented 5 years ago

Right now, we are tying the receipt of webmentions to the ping_status field in wp_post.

For one, it means that enabling webmentions means enabling pingbacks and trackbacks.

Want to contemplate the issue of whether or not we should have our own field for this that would be set only if webmentions are disabled for a post.

That merged with the existing webmention support feature by post type... with new setting in the awaiting PR, would allow complete disconnection from the pingback and trackback configuration.

pfefferle commented 5 years ago

We can add a separate setting for Webmentions, but then it has to be Gutenberg compatible!

janboddez commented 1 year ago

I'm running into this also. I implemented some of Webmention into a different (IndieBlocks ...) plugin and don't do any ping or trackback support checking. I just look at whether comments are open. (Or maybe I don't, and I simply assume inserting a comment will fail if the post doesn't accept them. I should probably look into that again.)

I'm now trying to make my plugins more compatible with the Webmention plugin. But this is something that seems to come back. Why tie webmention support to trackback support? Can't you just say, "If webmentions are enabled for this post type, and this particular post accepts comments, then that's enough"? (I guess this comes down to moving from "pings open" to "comments open.")

dshanske commented 1 year ago

That's exactly what I was contemplating with this... although it does lose the opportunity to manually disable Webmentions on a single post.

janboddez commented 1 year ago

Ah, that's true! If you wanted to accept only regular comments but not webmentions ...

A meta box + post meta would probably work for this sort of thing, also in Gutenberg. Because it's OK if the meta field gets saved "a tiny bit late." (Gutenberg does behave a bit weird when it comes to "old style" meta boxes/custom fields, in a race-condition-sort-of-way. Probably not a problem in this particular case.)

dshanske commented 10 months ago

I think I'm ready to start working on this in a few intermediate steps. Related, #425 and #235

  1. Replace all calls to pings_open with a new function that initially can just call pings_open
  2. Assume that anyone installing the webmention plugin wants webmentions open by default, again, we still have the disable by post type settings.
  3. Register a new meta field that, if it exists and is true, then it will reject webmentions.
  4. Amend the new function to pull from the field, but fallback to true.
  5. Use a meta box for Classic. And we can always add a setting in the Block Editor if someone is willing to add the code in future.

@pfefferle and co...what do you think?