search

pfefferle / wordpress-webmention

A Webmention plugin for WordPress
https://wordpress.org/plugins/webmention/
MIT License
115 stars 32 forks source link

Also use comment URL fragment for reply nesting? #463

Open janboddez opened 4 months ago

janboddez commented 4 months ago

I just published this reply to https://nicksimson.com/notes/941927cc48/#comment-782 (note the URL fragment), and noticed it didn't quite get "nested" correctly, at least not automatically.

It'd be nice, I guess, if the plugin took a guess and assumed this being in reply to another comment, and use the URL fragment to correctly nest the mention?

In IndieBlocks, I've attempted to do just that.

In Webmention, I noticed this bit of code that seems to store the fragment but not use it?

https://github.com/pfefferle/wordpress-webmention/blob/main/includes/class-receiver.php#L281-L298

Should I be using ?replytocom=<ID> instead? (I think we've discussed this before but I couldn't seem to find it back immediately.) Because that's not a URL that can readily be found. The "comment u-url" is the one with the fragment part, after all. (But I'm okay with adding the replytocom query argument as well, to improve compatibility.)

pfefferle commented 4 months ago

We discussed that for ActivityPub (which should not work because fragments are ignored by the server, so content negotiation wouldn't work), but I like the idea for Webmentions. Will work on an implementation!

Thanks for your report!