search

pfefferle / wordpress-webmention

A Webmention plugin for WordPress
https://wordpress.org/plugins/webmention/
MIT License
117 stars 31 forks source link

Fatal error due to broken comment query callback #470

Closed janboddez closed 4 months ago

janboddez commented 4 months ago

There's an issue here:

https://github.com/pfefferle/wordpress-webmention/blob/a9129f46da7c11876e8ff1a18ebfd90b332eaf81/includes/class-comment-walker.php#L295

This alters completely overwrites (but only when a meta_query array is present) $query, which is passed by reference.

And leads to a fatal error later on, when this code is run: https://github.com/pfefferle/wordpress-webmention/blob/a9129f46da7c11876e8ff1a18ebfd90b332eaf81/includes/class-comment-walker.php#L307

Originally reported at https://github.com/janboddez/indieblocks/issues/180.

pfefferle commented 4 months ago

Should be fixed on 5.3.1! Thanks for your fast help!